search

eclipse-sdv-blueprints / fleet-management

A close to real-life showcase for truck fleet management where trucks run an SDV software stack so that logistics fleet operators can manage apps, data and services for a diverse set of vehicles.
Apache License 2.0
16 stars 10 forks source link

Add support for using Eclipse Zenoh as transport between vehicle and back-end #36

Closed vivekpandey02 closed 7 months ago

vivekpandey02 commented 8 months ago

I am pleased to present a Pull Request marking the initiation of the Eclipse Zenoh integration into the Eclipse SDV FMS blueprint. This PR focuses on extending the FMS Forwarder to publish data via Zenoh, alongside configuring the Zenoh Router to receive data over MQTT. This integration sets the stage for the subsequent phase, where FMS consumer integration into the Zenoh Router will be addressed, further strengthening the capabilities of our Fleet Management System Blueprint. Please review the PR and provide the necessary feedback.

eriksven commented 8 months ago

Hello,

thank you for the PR.

Regarding the failing the "Lint source code / lint-source-code" Check: We just created a PR in #37, which should fix this issue.

Regarding the ECA-Check: When I click on the details the same address is listed as covered once and as not covered 14 times. Could it be that. you signed the ECA after making the respective commits?

eriksven commented 8 months ago

In the meantime we merged #37, so to resolve the linting error you can rebase to the current main-branch.

The issue with the ECA tool seems to have resolved itself in the meantime.

evshary commented 8 months ago

Thanks for the PR :-) Am I right in assuming that the Zenoh router will currently not forward data to influx DB?

Not yet. I believe this is the next step. Maybe will use the Zenoh router with the influxdb plugin to forward data.

sophokles73 commented 7 months ago

@vivekpandey02 are you still working on this?

vivekpandey02 commented 7 months ago

@vivekpandey02 are you still working on this?

Yes, I am working on it. i have changed the FMS-Consumer for zenoh support. Now FMS Consumer can take the data from Hono Kafka and Zenoh both and write into influxDB. so we introduced Zenoh in FMS Forworder, and FMS-Consumer Both. I will merge my code into my PR#36 soon

vivekpandey02 commented 7 months ago

@vivekpandey02 are you still working on this?

Hi @sophokles73, I have merged all the changes for Zenoh end to end communication in #PR36

vivekpandey02 commented 7 months ago

@vivekpandey02 are you still working on this?

Hi @sophokles73, I have merged all the changes for Zenoh end to end communication in #PR36

Hi @sophokles73, is there any comment / Feedback on PR #36 ?

vivekpandey02 commented 7 months ago

Hello @sophokles73, I've incorporated the changes based on your review comments in my pull request.

vivekpandey02 commented 7 months ago

Hi @sophokles73, I have done changes for the Zenoh Code for PR #36 as per your feedback.

vivekpandey02 commented 7 months ago

LGTM

Thanks for contributing and your patience 👍

I have seen that you have undone your changes to Cargo.lock, which is fine, I will make the required changes after merging. Do you want to squash your branch into a reasonable (small) number of commits, or should I do it when merging?

You're welcome! I appreciate your guidance and patience throughout the process. I'm glad to contribute to the project. I trust your judgment, so if you could handle the squashing during the merging process, that would be fantastic. I appreciate your cooperation.