Closed msmarioo closed 9 months ago
@nacidai Created an initial commit with very basic code and documentation to check the PR process.
This commit is part of #7
Hi Mario,
Can you add a simple copyright/license template to the files? Something along (ofcourse your version)
// SPDX-FileCopyrightText: 2023 Contributors to the Eclipse Foundation // // See the NOTICE file(s) distributed with this work for additional // information regarding copyright ownership. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. // // SPDX-License-Identifier: Apache-2.0
[like] Mario Ortegon Cabrera reacted to your message:
From: Naci Dai @.> Sent: Tuesday, January 30, 2024 1:05:48 PM To: eclipse-sdv-blueprints/insurance @.> Cc: Mario Ortegon Cabrera @.>; Author @.> Subject: Re: [eclipse-sdv-blueprints/insurance] Initial code commit (PR #12)
Hi Mario,
Can you add a simple copyright/license template to the files? Something along (ofcourse your version)
// SPDX-FileCopyrightText: 2023 Contributors to the Eclipse Foundation // // See the NOTICE file(s) distributed with this work for additional // information regarding copyright ownership. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. // // SPDX-License-Identifier: Apache-2.0
— Reply to this email directly, view it on GitHubhttps://github.com/eclipse-sdv-blueprints/insurance/pull/12#issuecomment-1916804661, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARO5DJ3BU66PJCI6TMG3INDYRDV2ZAVCNFSM6AAAAABCQ2TIAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJWHAYDINRWGE. You are receiving this because you authored the thread.Message ID: @.***>
Hi Naci,, Sure! Thanks for the feedback, that is why I wanted to try with a fairly simple commit. Do we also need this for the documentation? Or only for the source files?
Thanks,
From: Naci Dai @.> Sent: Tuesday, January 30, 2024 2:06 PM To: eclipse-sdv-blueprints/insurance @.> Cc: Mario Ortegon Cabrera @.>; Author @.> Subject: Re: [eclipse-sdv-blueprints/insurance] Initial code commit (PR #12)
Hi Mario,
Can you add a simple copyright/license template to the files? Something along (ofcourse your version)
// SPDX-FileCopyrightText: 2023 Contributors to the Eclipse Foundation // // See the NOTICE file(s) distributed with this work for additional // information regarding copyright ownership. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License. // // SPDX-License-Identifier: Apache-2.0
- Reply to this email directly, view it on GitHubhttps://github.com/eclipse-sdv-blueprints/insurance/pull/12#issuecomment-1916804661, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ARO5DJ3BU66PJCI6TMG3INDYRDV2ZAVCNFSM6AAAAABCQ2TIAGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMJWHAYDINRWGE. You are receiving this because you authored the thread.Message ID: @.***>
Yes it is best to have it in your source code, and all initial commits.
@nacidai Hi Naci, I have added a new commit to the PR with the licenses and additional documentation.
This PR also closses #2. The code includes a .devcontainer that installs the required python components.
Basic functionality stub including one documentation piece. Used to test the contribution process.