eclipse-sdv-blueprints / software-orchestration

Apache License 2.0
3 stars 4 forks source link

Add Ibeji, Agemo, and Freyja in-vehicle stack blueprint image workflow #17

Closed ladatz closed 1 month ago

ladatz commented 3 months ago

These github workflows checks out the eclipse-chariott/Agemo repository and eclipse-ibeji/ibeji repository and builds images with the configuration and settings needed to run in the integrated mode with the other workloads in the software-orchestration blueprint. It then pushes the resulting images to the blueprint GitHub container registry. The resulting images include:

ladatz commented 3 months ago

@eriksven Can we please "squash and merge" this one once it has been reviewed? I ended up with a lot of commits here. I'll make sure the next one is cleaner

eriksven commented 3 months ago

The workflows look good to me. I added a comment to add a full copyright header. Also there is a merge conflict with the chariott workflow. Can you resolve this?

For the merge I will use "squash and merge" this time.

ladatz commented 3 months ago

The workflows look good to me. I added a comment to add a full copyright header. Also there is a merge conflict with the chariott workflow. Can you resolve this?

For the merge I will use "squash and merge" this time.

I am looking for some confirmation from my team about the license question. I also cleaned up the history of this PR and added the Freyja workflow as well.

eriksven commented 1 month ago

@ladatz I missed to see that you already updated the license headers in this PR and merged #20 before now. Most likely as a result, there is now a merge conflict with the containerize-invehicle-stack-chariott.yml file. Can you resolve this?

ladatz commented 1 month ago

@ladatz I missed to see that you already updated the license headers in this PR and merged #20 before now. Most likely as a result, there is now a merge conflict with the containerize-invehicle-stack-chariott.yml file. Can you resolve this?

@ladatz I missed to see that you already updated the license headers in this PR and merged #20 before now. Most likely as a result, there is now a merge conflict with the containerize-invehicle-stack-chariott.yml file. Can you resolve this?

@eriksven No problem, I have resolved the merge conflict now.