search

eclipse-sensinact / org.eclipse.sensinact.gateway

Eclipse Public License 2.0
7 stars 14 forks source link

API tidy up #496

Open timothyjward opened 1 week ago

timothyjward commented 1 week ago

We are cleaning down before attempting a milestone release. This means that we don't need a final release API, but it would be good to make sure things are in a good shape first.

This issue is to gather changes that may need to be made. Please add types/packages that you think need to be cleaned.

timothyjward commented 1 week ago

The NotificationAccumulator interface is available from the GatewayThread and present in the AbstractSensinactCommand. This is an important type but I can't understand the need for it to be public API. Would we ever expect a user to call any of the methods? If they did it could cause chaos by sending events with unvalidated changes....

@tcalmant @juergen-albert @maho7791 @stbischof - should this remain public, or shall I investigate making it a private implementation detail?

stbischof commented 1 week ago

I have to look deeper. But in general it is easy do add a method or class in api in a minor change then removing it an i major.