search

eclipse-shellwax / shellwax

Shell script editor plugin for Eclipse
https://marketplace.eclipse.org/content/shellwax
Eclipse Public License 2.0
17 stars 12 forks source link

Some UI Freeze on hover when man documentation is huge #18

Closed mickaelistria closed 1 year ago

mickaelistria commented 5 years ago

I got several freezes of shellwax today when it attempted to give me hover information for dbus-daemon. Here is the stacktrace

"main" #1 prio=6 os_prio=0 cpu=215657.60ms elapsed=1835.72s tid=0x00007f0238012800 nid=0x1459 runnable  [0x00007f023d20c000]
   java.lang.Thread.State: RUNNABLE
    at org.eclipse.swt.internal.gtk.OS._pango_layout_get_line_count(Native Method)
    at org.eclipse.swt.internal.gtk.OS.pango_layout_get_line_count(OS.java:3762)
    at org.eclipse.swt.graphics.TextLayout.getLineBoundsInPixels(TextLayout.java:981)
    at org.eclipse.swt.graphics.TextLayout.getLineBounds(TextLayout.java:976)
    at org.eclipse.jface.internal.text.html.BrowserInformationControl.computeSizeHint(BrowserInformationControl.java:441)
    at org.eclipse.jface.text.AbstractInformationControlManager.internalShowInformationControl(AbstractInformationControlManager.java:1174)
    at org.eclipse.jface.text.AbstractInformationControlManager.presentInformation(AbstractInformationControlManager.java:1120)
    at org.eclipse.jface.text.AbstractHoverInformationControlManager.presentInformation(AbstractHoverInformationControlManager.java:884)
    at org.eclipse.jface.text.TextViewerHoverManager.doPresentInformation(TextViewerHoverManager.java:251)
    at org.eclipse.jface.text.TextViewerHoverManager.lambda$0(TextViewerHoverManager.java:241)
    at org.eclipse.jface.text.TextViewerHoverManager$$Lambda$776/0x0000000840cf4440.run(Unknown Source)

I think this could have a workaround in LSP4E. The "BrowserInformationControl" it creates should try to override computeSizeHint so if text is long (more than 50 lines for instance), it returns a dummy value.

akurtakov commented 4 years ago

@mickaelistria do you still reproduce this one?

mickaelistria commented 4 years ago

yes, my script contains the dbus-daemon command and when cursor stays on it for too long, I get a UI Freeze. I'm using latest snapshot build.

mickaelistria commented 4 years ago

It's an occurence of upstream bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=552373

akurtakov commented 1 year ago

I can no longer reproduce this one. If you can't reproduce it too please close.

akurtakov commented 1 year ago

No reply. Closing.