search

eclipse-sirius / sirius-desktop

Sirius Desktop: desktop-based graphical modelers for dedicated DSLs
https://eclipse.dev/sirius/
Eclipse Public License 2.0
13 stars 11 forks source link

AbstractSpecificDDiagramEditor code/documentation is stale #225

Open ewillink opened 6 months ago

ewillink commented 6 months ago

Effectively reopening https://bugs.eclipse.org/bugs/show_bug.cgi?id=467632

I'm trying to bind a Sirius editor direct to a *.aird file which seems to be pretty much what https://github.com/pcdavid/org.eclipse.sirius/blob/master/plugins/org.eclipse.sirius.doc/doc/developer/later/extensions-provide_custom_specific_editor.txt offers.

However using the example MySpecificEditor snippet fails with many missing methods (because AbstractSpecificDDiagramEditor hasn't been maintained for 9 years, possibly ever) and strangely gets an 'impossible' type hierarchy is inconsistent error.

ewillink commented 6 months ago

gets an 'impossible' type hierarchy is inconsistent error

This may be cured by adding the indirect bundle dependencies for org.eclipse.gmf.runtime.diagram.ui.resources.editor and org.eclipse.gmf.runtime.diagram.ui to the MANIFEST.MF. (JDT really should have helped.) Then the three overrides seem much more plausible.