Quick fix for images not found needs a "Validate diagram" action before each quick fix

[GlennPlou]

See bugzilla https://bugs.eclipse.org/bugs/show_bug.cgi?id=581808 Steps to reproduce:

• Import the attached project 581808_validation.zip and open the representation "new ClassDiagram_581808".
• Open the "Problems" view. Click on the diagram background and run "Validate Diagram" action
• For each of the 3 errors in Problems view, click on "Quick fix", then "Image remove: remove broken reference to image in diagram" and Finish Expected: The fix is applied with each qui fix Actual: The first quick fix is properly applied. The second and third quick fix aren't applied. A "Validate Diagram" action needs to be run before each quick fix to apply them.

[scosta-obeo]

I can see that this is the case for any Quick Fix. An other example to reproduce with Basic Family Sample:

• Open example "Basic Family Metamodel Definition" (in File > New > Example... > Sirius Examples)
• Launch a runtime (right click on any project, then, Run As > Eclipse Application)
• In the runtime, open the example "Basic Family Modeler Definition - Advanced Tutorial Solution" and "Basic Family Sample Model"
• On the object "Family" of the model example.basicfamily, create new representation "Persons diagram" and open this diagram.
• Select "Paul" and set its parent to "Paul" using the property view.
• Select "Albert" and set its parent to "Albert" using the property view.
• Run the validation on the diagram (right click > Validate diagram)
• Expected: 2 errors (one for Albert and one for Paul)
• On the first error: right click > Quick fix > Finish
• Expected: the first invalid parent/child relation has been deleted and the associated problem.
• On the second error: right click > Quick fix > Finish
• Expected: the second invalid parent/child relation has been deleted and the associated problem.
• Actual: nothing.