PR to fix the wrong border node location creation problem 2

eclipse-sirius / sirius-desktop

Sirius Desktop: desktop-based graphical modelers for dedicated DSLs

https://eclipse.dev/sirius/

Eclipse Public License 2.0

15 stars 12 forks source link

PR to fix the wrong border node location creation problem 2 #434

Open mypsycho opened 3 months ago

mypsycho commented 3 months ago

Bug: #396 Complement of #404.

Draft : org.eclipse.sirius.tests.swtbot.BorderedNodeCreationTest#testBNC_OnVStackContainer() is still failing but with expected:<Point(393.0, 445.0)> but was:<Point(384.0, 410.0)> instead of expected:<Point(393.0, 445.0)> but was:<Point(153.0, 326.0)> The shift may come from the assertion targeting the wrong container.

lredor commented 2 months ago

The cleanup commits have been copied into PR #455. A slightly different approach has been chosen in the PR #455 instead of the commit "[396] Add LayoutData when creating node in Stack Container." proposed in the current PR. The current PR will be closed/abandoned if all validation steps will be OK for PR #455.