search

eclipse-sirius / sirius-emf-json

JSON-based EMF Resource implementation - part of Eclipse Sirius
https://eclipse.dev/sirius/sirius-web.html
Eclipse Public License 2.0
5 stars 10 forks source link

Convert into a plain Maven project/module #37

Open pcdavid opened 1 month ago

pcdavid commented 1 month ago

AFAICT, this project is only used in Sirius Web, which is a plain Maven project. The fact that it is designed to be built as an Eclipse plug-in first, and a Maven artefact second makes things more complex for no real benefit IMO. There is actually very little code in the Eclipse-specific org.eclipse.sirius.emfjson.ide (mostly JsonDescriber.java).

sbegaudeau commented 1 month ago

You could drop the question mark from the title :) We should definitively move into this direction when we will have some time. It's very painful to test emfjson while working on API changes with Sirius Web at the moment. It has been an issue for multiple contributors in the past few months.

pcdavid commented 1 month ago

A more radical approach would be to move this directly inside Sirius Web. As long as the corresponding module does not have move dependencies as it has now, it could still be consumable as a Maven dependency, just using different coordinates, e.g.

<dependency>
  <groupId>org.eclipse.sirius</groupId>
  <artifactId>sirius-components-emf-json</artifactId>
  <version>2024.7.0-SNAPSHOT</version>
</dependency>

instead of

<dependency>
  <groupId>org.eclipse.sirius.emfjson</groupId>
  <artifactId>org.eclipse.sirius.emfjson</artifactId>
  <version>2.3.8-SNAPSHOT</version>
</dependency>