eclipse-sirius / sirius-web

Sirius Web: open-source low-code platform to define custom web applications supporting your specific visual languages
https://eclipse.dev/sirius/sirius-web.html
Eclipse Public License 2.0
79 stars 52 forks source link

The `views` variable for OperationActions from odesigns is not available in a web context #1812

Open sezginaytac opened 2 years ago

sezginaytac commented 2 years ago

Hi, sirius-web is very excited me especially due to that domain models and represetations can be designed and existing odesign files can be used!

I want to edit bpmn2 diagrams in sirius-web. After a small effort, I displayed your Travel Agency sample bpmn2 diagram pretty well. But I have 2 problems: 1- in the details pane, attribute labels are blank 2- in the context menu for actions, majority of actions are not available, so new objects can be created with the treeviewer only

I ' ve attached the screen capture below about those problems. For the first problem I have tried to add ILabelFeatureProvider Bpmn2LabelFeatureProvider() bean into SampleEMFConfiguration, but nothing happened. I think those beans are for objects (i.e. displayed as boxes or arrows) instead of attributes.

Can you provide some hints for how I can overcome those problems?

Many thanks in advance...

sirius-web-bpmn2-issue-001

sbegaudeau commented 2 years ago

Hi,

I think that this commit merged 6 days ago should have fixed this issue. Can you reproduce it on master?

Kind regards

sbegaudeau commented 2 years ago

The issue was caused by the fact that the BPMN Designer is depending on an Eclipse EEF utility method but eef was not included by default in the classpath by the Sirius Components compatibility layer.

sezginaytac commented 2 years ago

Waooowww, the first problem solved as you said. After checking out the current master, attributes are displayed as expected. Special thanks for your quick response

Can you provide some hints for the second problem? In the context menu for actions, majority of actions are not available, so new objects can be created with the treeviewer only.

Best regards,

sbegaudeau commented 2 years ago

For the second issue, I'm not sure it may be related to the newly introduced support for preconditions on the tools.

sezginaytac commented 2 years ago

Such warnings are displayed in the console, may support your thought:

2022-04-05 21:46:40.136 WARN 22564 --- [fb-94988d0193a2] o.e.s.c.interpreter.AQLInterpreter : An error has occurred with the expression 'aql:views->first().target.oclIsKindOf(bpmn2::Event)': Couldn't find the 'views' variable 2022-04-05 21:46:40.136 WARN 22564 --- [fb-94988d0193a2] o.e.s.c.interpreter.AQLInterpreter : A warning has occurred with the expression 'aql:views->first().target.oclIsKindOf(bpmn2::Event)': Couldn't find the 'first(org.eclipse.acceleo.query.runtime.impl.Nothing)' service 2022-04-05 21:46:40.137 WARN 22564 --- [fb-94988d0193a2] o.e.s.c.interpreter.AQLInterpreter : A warning has occurred with the expression 'aql:views->first().target.oclIsKindOf(bpmn2::Event)': Couldn't find the 'aqlFeatureAccess(org.eclipse.acceleo.query.runtime.impl.Nothing,java.lang.String)' service 2022-04-05 21:46:44.621 WARN 22564 --- [fb-94988d0193a2] o.e.s.c.interpreter.AQLInterpreter : An error has occurred with the expression 'aql:views->first().target.oclIsKindOf(bpmn2::Event)': Couldn't find the 'views' variable 2022-04-05 21:46:44.622 WARN 22564 --- [fb-94988d0193a2] o.e.s.c.interpreter.AQLInterpreter : A warning has occurred with the expression 'aql:views->first().target.oclIsKindOf(bpmn2::Event)': Couldn't find the 'first(org.eclipse.acceleo.query.runtime.impl.Nothing)' service 2022-04-05 21:46:44.622 WARN 22564 --- [fb-94988d0193a2] o.e.s.c.interpreter.AQLInterpreter : A warning has occurred with the expression 'aql:views->first().target.oclIsKindOf(bpmn2::Event)': Couldn't find the 'aqlFeatureAccess(org.eclipse.acceleo.query.runtime.impl.Nothing,java.lang.String)' service

pcdavid commented 2 years ago

"Couldn't find the 'views' variable" seems to be the root of all the other messages, and indeed in Sirius Web the views variable is not available in the evaluation context.

As mentioned by @sbegaudeau it seems related to tools' preconditions, see https://github.com/ObeoNetwork/BPMN-Designer/blob/master/plugins/org.obeonetwork.dsl.bpmn2.design/description/BPMN2.odesign#L2890

pcdavid commented 1 year ago

Related to https://github.com/eclipse-sirius/sirius-components/issues/719.