search

eclipse-sirius / sirius-web

Sirius Web: open-source low-code platform to define custom web applications supporting your specific visual languages
https://eclipse.dev/sirius/sirius-web.html
Eclipse Public License 2.0
79 stars 52 forks source link

Remove our custom EditingContextCrossReferenceAdapter #4134

Open pcdavid opened 3 weeks ago

pcdavid commented 3 weeks ago

It's not clear what it does (or more precisely, that what it does adds some value compared to EMF's default behavior). When replacing it with EMF's standard ECrossReferenceAdapter I don't see any regression (at least all the integration tests pass). Note that even in it's own EditingContextCrossReferenceAdapterTest, when not installing it in testMoveObject the test still passes.

It has at least one specific issue (#1400, though I can't reproduce it on master)

Note that we still need to install an ECrossReferenceAdapter because IncomingTreeDescriptionProvider needs fast inverse cross references lookup (SysON too).

pcdavid commented 2 weeks ago

One scenario to validate before we can actually remove our custom adapter is to define multiple View documents with references between them (typically through reused node description), and make sure they are correctly reloaded from scratch (editing domain disposed) with the inter-document references properly resolved.