search

eclipse-sisu / sisu-project

Sisu Inject
https://www.eclipse.org/sisu
Eclipse Public License 2.0
17 stars 15 forks source link

Disable annotation processor by default #105

Closed kwin closed 5 months ago

kwin commented 5 months ago

This closes #104

slawekjaranowski commented 5 months ago

Should be document how to enable without - META-INF/services/javax.annotation.processing.Processor

mcculls commented 5 months ago

Should be document how to enable without - META-INF/services/javax.annotation.processing.Processor

Agree - another option would be to leave the services entry in place and use a system property to enable/disable (off by default)

kwin commented 5 months ago

use a system property to enable/disable

As this is core functionality of Javac I wouldn't introduce another toggle: https://docs.oracle.com/javase/8/docs/technotes/tools/unix/javac.html#BHCDIFEE -> option -processor <classname>. I will enrich the readme and site.

kwin commented 5 months ago

@mcculls Is https://github.com/eclipse/sisu.inject/blob/master/docs/index.html really manually crafted or created by some tool (if yes from what source)? WDYT about switching to a standardized Maven site here as well leveraging markdown?