eclipse-sisu / sisu-project

Sisu Inject
https://www.eclipse.org/sisu
Eclipse Public License 2.0
17 stars 15 forks source link

Fix Jacoco coverage repots in Sonar #136

Closed cstamas closed 1 month ago

cstamas commented 1 month ago

Now that inject and plexus are consolidated, they should not step on each other toe, and write to top level target directory the report.

This does NOT fix Sonar, that for me, unknown reason, does not pick up generated Jacoco reports. Still, the reports on local builds are there and are usable.

cstamas commented 1 month ago

So, coverage is not picked up by Sonar... unsure why :thinking:

cstamas commented 1 month ago

Am giving up this fight with Sonar, anyone any clue?

kwin commented 1 month ago

Is this really that hard to achieve with Maven as outlined in https://github.com/jacoco/jacoco/wiki/MavenMultiModule? I think implementing a https://maven.apache.org/ref/3.9.7/maven-core/apidocs/org/apache/maven/execution/AbstractExecutionListener.html in Jacoco should allow to get rid of this additional module. WDYT @cstamas?

cstamas commented 1 month ago

No idea. Imho this is not jacoco (if you build locally all the files and reports are properly in place: per module reports but also the aggrgated one). It is more about sonat not picking up them, like it have clue where to look?

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud