Date: 2013-09-20 15:33:46 -0400
From: Stuart McCulloch <mcculls@gmail.com>
Also mark that it is technically a @Scope to make sure people don't add other scopes on the same location by mistake. Note: this may require us to register a placeholder scope implementation to keep Guice happy, even though we really map @EagerAnnotation to <binding>.asEagerSingleton() when analysing the bindings.
Comment 2346285
Date: 2014-01-06 19:36:46 -0500
From: Stuart McCulloch <mcculls@gmail.com>
Date: 2014-01-06 19:40:14 -0500
From: Stuart McCulloch <mcculls@gmail.com>
Decided not to widen the places where @EagerSingleton can be applied, as currently Sisu only respects this pseudo-scope annotation on classes. Because it wouldn't work applied to a provider method in a module then we should not allow it.
Comment 2346733
Date: 2014-01-07 20:00:47 -0500
From: Stuart McCulloch <mcculls@gmail.com>
Deferring until a later milestone due to side-effects of marking this with @Scope: namely that Guice then expects you to bind a Scope implementation to the annotation when re-using the component outside of Sisu.
This issue was created automatically with bugzilla2github
Bugzilla Bug 417720
Date: 2013-09-20 15:33:46 -0400 From: Stuart McCulloch <mcculls@gmail.com> To: Project Inbox <sisu-inbox@eclipse.org>
Last updated: 2014-02-03 19:47:44 -0500
Comment 2309386
Date: 2013-09-20 15:33:46 -0400 From: Stuart McCulloch <mcculls@gmail.com>
Also mark that it is technically a
@Scopeto make sure people don't add other scopes on the same location by mistake. Note: this may require us to register a placeholder scope implementation to keep Guice happy, even though we really map@EagerAnnotationto<binding>.asEagerSingleton()when analysing the bindings.Comment 2346285
Date: 2014-01-06 19:36:46 -0500 From: Stuart McCulloch <mcculls@gmail.com>
See http://git.eclipse.org/c/sisu/org.eclipse.sisu.inject.git/commit/?id=11ec7efbe1e2c4a1b27cdca5d5a86a4fe2ea15a0
Comment 2346287
Date: 2014-01-06 19:40:14 -0500 From: Stuart McCulloch <mcculls@gmail.com>
Decided not to widen the places where
@EagerSingletoncan be applied, as currently Sisu only respects this pseudo-scope annotation on classes. Because it wouldn't work applied to a provider method in a module then we should not allow it.Comment 2346733
Date: 2014-01-07 20:00:47 -0500 From: Stuart McCulloch <mcculls@gmail.com>
Deferring until a later milestone due to side-effects of marking this with
@Scope: namely that Guice then expects you to bind a Scope implementation to the annotation when re-using the component outside of Sisu.