eclipse-sisu / sisu-project

Sisu Inject
https://eclipse.dev/sisu/
Eclipse Public License 2.0
18 stars 15 forks source link

Upgrade ASM in Sisu to 9.2 (Bugzilla Bug 546874) #29

Closed mcculls closed 2 years ago

mcculls commented 2 years ago

This issue was created automatically with bugzilla2github

Bugzilla Bug 546874

Date: 2019-04-30 13:35:25 -0400 From: Robert Scholte <eclipse@sourcegrounds.com> To: Stuart McCulloch <mcculls@gmail.com> CC: mcculls@gmail.com

Last updated: 2019-11-05 19:10:55 -0500

Comment 3034851

Date: 2019-04-30 13:35:25 -0400 From: Robert Scholte <eclipse@sourcegrounds.com>

According to https://issues.apache.org/jira/browse/MNG-6580 Sisu is not capable in scanning Java class files with target/release 9+ due to an old version of ASM. I've marked it as critical since there's no workaround (other than staying on a n older Java version).

Comment 3093146

Date: 2019-11-05 19:10:55 -0500 From: Stuart McCulloch <mcculls@gmail.com>

I've put a small workaround in the 0.3.4 release which means the scanner now attempts to scan bytecode up to and including the Java 14 level. This was possible because the scanner only does a light scan of the class file and isn't affected by recent bytecode additions.

I'll leave this ticket open as I still want to get master onto the latest ASM release.

bentmann commented 2 years ago

Getting Sisu on a newer ASM version to play nice with current Java versions would be really nice.