eclipse-sisu / sisu-project

Sisu Inject
https://www.eclipse.org/sisu
Eclipse Public License 2.0
17 stars 15 forks source link

Make build work with Java17 #61

Closed cstamas closed 1 year ago

cstamas commented 1 year ago

In short: now build works on both, Java 11 and Java 17 (tested with 11 and 17 Temurin on Linux).

Also, build (plugins and tooling) is updated as well, dependencies are NOT touched except logging: they are set to slf4j 1.7.36 and logback 1.1.11. Reason is that (in tests) they were "crossed": slf4j 1.6 was used with 1.1.11 logback (while logback 1.1.x requires 1.7.x slf4j). So, dependencies can be set back (slf4j 1.6.x and logback 1.0.0) but then it needs to be consequently set (target AND test POM).

Changes:

Java 17 changes (commit 8fa9020c2faa5b7c1603e62e74668a64c4a69032):

cstamas commented 1 year ago

Frankly, I'd drop this PR and rather continue with https://github.com/eclipse/sisu.inject/pull/71 that incorporates this one as well....

cstamas commented 1 year ago

Superseded by https://github.com/eclipse/sisu.inject/pull/71