eclipse-sisu / sisu-project

Sisu Inject
https://eclipse.dev/sisu/
Eclipse Public License 2.0
18 stars 15 forks source link

Support for jakarta namespace #92

Open cstamas opened 1 year ago

cstamas commented 1 year ago

Just a discussion starter: "what do we plan with jakarta namespace"?

Guice released "transitional" 6.0.0 (supporting both, javax and jakarta) and 7.0.0 (supporting jakarta only). Apps using sisu built from the scratch may want to choose jakarta, while Maven (due legacy, especially 4.x) may want to "sit tight" on javax still.... (just to note, supporting newer bytecode is doable with "external asm").

HannesWell commented 10 months ago

Supporting jakarta annotations would be great. The Eclipse E4 Dependency Injector is currently capable to handle both, jakarta and javax annotations and is prepared to handle the absence of javax annotations in the runtime (jakarta absence would of course be possible). Just in case you want to use a similar strategy: https://github.com/eclipse-platform/eclipse.platform/pull/792

rfscholte commented 1 week ago

The question is how to implement this in the SpaceModule and ClassFinder? Does the user need to select one of both, or should there be scanned for both?