search

eclipse-sisu / sisu-project

Sisu Inject
https://www.eclipse.org/sisu
Eclipse Public License 2.0
17 stars 15 forks source link

Do not silently fail in case of class scanning exceptions #98

Closed kwin closed 5 months ago

kwin commented 8 months ago

This closes #97

kwin commented 8 months ago

@cstamas Any idea how to make this configurable from Maven? Do we really want to extend the Plexus Container API for that?

kwin commented 8 months ago

@mcculls Can you be more specific, where exactly you want to keep the default behaviour of being lenient?

  1. https://github.com/eclipse/sisu.inject/blob/d2a7e64ad07a026ad488b042a37744e66ff9a75e/org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/space/SisuIndex.java#L95
  2. https://github.com/eclipse/sisu.inject/blob/d2a7e64ad07a026ad488b042a37744e66ff9a75e/org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/space/SpaceModule.java#L169
  3. https://github.com/eclipse/sisu.inject/blob/d2a7e64ad07a026ad488b042a37744e66ff9a75e/org.eclipse.sisu.inject/src/main/java/org/eclipse/sisu/space/QualifierCache.java#L83

or anywhere else (which I missed in the list above)

kwin commented 7 months ago

@mcculls Can you comment on the individual cases listed above?

mcculls commented 5 months ago

SisuIndex can be strict by default because it's build-time - everything else should be non-strict by default, with an option to make them strict.

kwin commented 5 months ago

everything else should be non-strict by default, with an option to make them strict.

@mcculls done now, can you check again?

kwin commented 5 months ago

If there are no further concerns @mcculls I am gonna merge end of this week.