eclipse-sisu / sisu.plexus

Sisu Plexus
https://www.eclipse.org/sisu
Eclipse Public License 1.0
4 stars 11 forks source link

Restore leniency when parsing nested elements #40

Closed marcphilipp closed 1 year ago

marcphilipp commented 1 year ago

Prior to e0140ba322c1fb02a9f43078290195c6ba882a66, elements with children and a name other than property were ignored. We have code that relies on this to declare additional configuration for the maven-surefire-plugin that is later read from the XppDom object. This commit restores the prior leniency for nested elements and ignores all elements with children that don't have both a name and a value child element.

kwin commented 1 year ago

@marcphilipp Any chance you can add a test case?

cstamas commented 1 year ago

Unsure this PR is needed, as @marcphilipp found a fix for this (using lifecycle participant, that extracts and rewrites plugin configurations). So please confirm Marc.

This PR should be "on hold", not to be merged.

marcphilipp commented 1 year ago

Indeed, I found a fix by "filtering" Xpp3Dom before passing it to the converter.