eclipse-sparkplug / sparkplug

Sparkplug
Eclipse Public License 2.0
115 stars 39 forks source link

Bug Report: `FloatArray` and `DoubleArray` examples in Sparkplug Specification have incorrect endianness. `DateTimeArray` and `Int8Array` examples also wrong. #435

Open ian-abbott opened 1 year ago

ian-abbott commented 1 year ago

What happened?

In Sparkplug specification 3.0.0 section 6.4.17, the byte strings for FloatArray and DoubleArray examples are shown with the wrong byte order.

For FloatArray, specification 3.0.0 has this example:

It should be:

For DoubleArray, specification 3.0.0 has this example:

It should be:

Also, the example for DateTimeArray does not have enough bytes (2 most significant bytes missing from each value):

It should be:

Also, the example for Int8Array uses the wrong byte for -23:

It should be:

What is the product or software this issue was discovered with?

Sparkplug Specification 3.0.0

What exact steps need to be performed to reproduce the problem?

None.

Is this related to a Sparkplug Listing request? If so, link the issue from https://github.com/eclipse-sparkplug/sparkplug.listings here.

No response

Version

3.0.0 (Default)

Accept EFTL Terms

ian-abbott commented 1 year ago

I edited the report to also include an incorrect example for DateTimeArray in the specification.

ian-abbott commented 1 year ago

I edited the report again to include an incorrect example for Int8Array in the specification.