search

eclipse-sparkplug / sparkplug

Sparkplug
Eclipse Public License 2.0
109 stars 39 forks source link

Fix: Change hasValue to call hasIntValue for uint32 datatypes #467

Closed luke-shields closed 1 year ago

luke-shields commented 1 year ago

Currently, the hasValue function with Utils.java calls hasLongValue when the datatype is 7 (uint32).

This does not align with the Google Protobuf Language Guide which states that uint32 Protobuf values map to an Int type in Java.

https://protobuf.dev/programming-guides/proto3/ (Under 'Scalar Value Types')

This PR fixes this.

luke-shields commented 1 year ago

Fix covered in improved manner in PR: https://github.com/eclipse-sparkplug/sparkplug/pull/469