Fix data type checks develop

luke-shields commented 1 year ago

This PR forward ports fixes made to the 3.x branch to the develop branch

This PR fixes three bugs and makes some improvement: Bugs

If PAYLOADS_METRIC_PROPERTYVALUE_TYPE_VALUE is found to be invalid for one payload however valid for a subsequent payload, the test is passed. If this test fails once, it should be recorded as a fail.
PAYLOADS_METRIC_PROPERTYVALUE_TYPE_VALUE Checks PropertyValue.Type against the wire values: int_value = 3; uint64 long_value = 4; float float_value = 5; It should be checked against the enum 'DataType'
Metric.hasValue checks for an uint64 when datatype 7 (uint32) is passed in. This should check for a uint32 value

Other changes

Switch hasValue functions to use ValueCase and shift datatype validation into separate functions

Please comment any questions regarding this PR

luke-shields commented 12 months ago

Hi all, is anything preventing this being merged? It would be helpful to have these fixes on the develop branch

luke-shields commented 10 months ago

Any update here? It would be helpful for us to have these changes on the develop branch

icraggs-sparkplug commented 10 months ago

@wes-johnson These are the same changes as have already been merged into the 3.x branch. Good to merge.

eclipse-sparkplug / sparkplug