Check NDEATH for matching bdseq - ignore otherwise #502

eclipse-sparkplug / sparkplug

Sparkplug

Eclipse Public License 2.0

109 stars 39 forks source link

Check NDEATH for matching bdseq - ignore otherwise #502 #524

Closed icraggs-sparkplug closed 4 months ago

icraggs-sparkplug commented 4 months ago

Fixing issue #502 - match NDEATH bdseq with NBIRTH..

I'm not entirely sure about this one - does the change leave us open to other errors such as the edge node issuing NDEATHS with wrong bdSeqs, in the case of the DONT_EXPECT_DEATHS state?

wes-johnson commented 4 months ago

I think it's ok to not worry about Edge Nodes sending invalid NDEATHs in this case. If they do this incorrectly, I would think they would also do it incorrectly in a valid OFFLINE state message with a current timestamp. So, I think we'd catch their flaw anyway.