search

eclipse-sprotty / sprotty-server

Server implementation for the Sprotty diagramming framework
https://eclipse.org/sprotty
Eclipse Public License 2.0
23 stars 19 forks source link

GH-13: Made the language client class configurable in the launchers. #14

Closed kittaakos closed 5 years ago

kittaakos commented 5 years ago

Closes #13.

Signed-off-by: Akos Kitta kittaakos@typefox.io

spoenemann commented 5 years ago

LSP4J also allows to declare multiple remote service interface, which can be useful in case your extension does not inherit from LanguageClient. While we're at it, should we also support that, or do you think that's unnecessary?

kittaakos commented 5 years ago

should we also support that, or do you think that's unnecessary?

I would cover it when we have the use-case.

While we're at it

What somewhat bugs me is why did I have to change the code at two different places? Perhaps we can extract the common code within this PR. What do you think?

spoenemann commented 5 years ago

What somewhat bugs me is why did I have to change the code at two different places? Perhaps we can extract the common code within this PR. What do you think?

If you have an idea for doing it, sure!

kittaakos commented 5 years ago

I have updated the PR and exposed the client class in the server setup so both launchers can use it.

Out of curiosity; should I avoid "fixing" the whitespaces in the future or not? I can revert the whitespace changes for this PR too.

JanKoehnlein commented 5 years ago

Thanks for the patch, @kittaakos.

In this repo we don't care that much about whitespace. Editing Xtend files in Eclipse usually adds the TABS to empty lines, and formatting would remove them.