search

eclipse-sprotty / sprotty-server

Server implementation for the Sprotty diagramming framework
https://eclipse.org/sprotty
Eclipse Public License 2.0
23 stars 19 forks source link

Fix NPE #45

Closed BoykoAlex closed 5 years ago

BoykoAlex commented 5 years ago

If new size (i.e. label size) is null NPE would occur

Signed-off-by: BoykoAlex aboyko@pivotal.io

BoykoAlex commented 5 years ago

Yes. There was nothing extra-ordinary. Client and server layout set to true. Request bounds sent to client. ComputedBounds comes back and goes into ComputeBoundsApplicator. NPE occurs for each label size.

BoykoAlex commented 5 years ago

Let me double-check.... I use git repo dependency for the client bits and 0.7.0. snapshot for the server via maven. Let me double-check that i still get that NPE...

BoykoAlex commented 5 years ago

NVM this issue, I don't see this NPE anymore with the dependencies above... I had 0.7.0-next for the webclient previously and seems like old snapshot was cached... NPE is gone, closing the PR

JanKoehnlein commented 5 years ago

As it's a breaking API changes, we should maybe log a message to check for the client version.