search

eclipse-sprotty / sprotty-server

Server implementation for the Sprotty diagramming framework
https://eclipse.org/sprotty
Eclipse Public License 2.0
23 stars 19 forks source link

Selected items state inconsistent #60

Closed tomvdbussche closed 4 years ago

tomvdbussche commented 4 years ago

When receiving a SelectAction from the client, the list of selected elements is cleared every time. This can result in an inconsistent state when selecting more items without deselecting them. The part in question: https://github.com/eclipse/sprotty-server/blob/db286b003a938ad862bc2da4441233e88434ed9b/org.eclipse.sprotty/src/main/java/org/eclipse/sprotty/DefaultDiagramServer.java#L479-L480

Additionally when dispatching a SelectAction or SelectAllAction from the server, the selected items in the state remain unchanged.