search

eclipse-sprotty / sprotty-server

Server implementation for the Sprotty diagramming framework
https://eclipse.org/sprotty
Eclipse Public License 2.0
23 stars 19 forks source link

update versions to conform to javax->jakarta.inject namespace change #85

Closed NiklasRentzCAU closed 4 months ago

NiklasRentzCAU commented 8 months ago

As the javax namespace is currently being phased out in newer releases, Sprotty should also jump on the train and replace old javax dependencies to work together with newer releases. Especially the latest Google Guice (com.google.inject) 7.0 release completely changes over from javax.inject to jakarta.inject dependencies, thus breaking the dependency injection of Sprotty when combined with newer versions.

In this PR I upgraded some dependencies to be more in line with the latest Eclipse 2023-09 release, especially the dependency injection framework.

I tried also updating the Java build version from 1.8 to 11, which caused unexpected build errors and Xtext and LSP4J to newer versions, which caused unexpected test errors (thrown exceptions because JUnit did not find any but expected tests in the TestLanguage classes).

This is a start to fix the injection issues with newer versions. To fully fix the problem with injecting the correct instances into extensions of the DefaultDiagramServer class with bindings in an extension to the DefaultDiagramModule class, the Xtext version probably needs to be updated as well.

What do you think of clearing up and updating the versions to release a new Sprotty server component soon? Currently in KLighD I have to resort to a workaround by re-injecting all fields of the DefaultDiagramServer so that it uses the correct injection framework namespace again.

spoenemann commented 4 months ago

We forgot to merge this after approval. The changes are now included in #87.