search

eclipse-sprotty / sprotty-theia

Integration of Sprotty diagrams into Theia IDE
https://eclipse.org/sprotty
Eclipse Public License 2.0
24 stars 14 forks source link

sprotty-theia only meant for "latest" Theia apps? #60

Closed marcdumais-work closed 4 years ago

marcdumais-work commented 4 years ago

Latest "next" release contains dependencies to Theia "latest"

version: 0.9.0-next.72ba049

package.json contains solid revisions of depended-upon Theia extensions : 

"dependencies": {
    "@theia/core": "1.0.0",
    "@theia/editor": "1.0.0",
    "@theia/filesystem": "1.0.0",
    "@theia/languages": "1.0.0",
    "@theia/monaco": "1.0.0",
    "sprotty": "next"
  }

This makes this extension unsuitable to be included in a next Theia application - mixing latest and next can sometimes build, but the app fails to start at runtime.

Maybe this is intended? i.e. the way "next" is used seems to apply only to sprotty - effectively it's still a latest extension as far as Theia is concerned, which can be confusing.

spoenemann commented 4 years ago

See #61: Using ^1.0.0 both in latest and next releases could resolve the problems?

marcdumais-work commented 4 years ago

For latest releases of sprotty-theia I think we're ok with the proposal in #61. But I do not think that will be enough for next releases. The Theia dependencies listed above would need to be exactly next think.