Closed ritzerp closed 8 months ago
AFAIK param keys have to be unique within the entity for which they are defined. The example shows multiple use of "speedTable", "traction", "resistance". The easy and ugly solution would be to concatenate all values of the same key to a single value.
So you mean something like this?
<param key="speedValues" value="0 50 100"/>
<param key="tractionValues" value="150000 150000 84000"/>
<param key="resistanceValues" value="2600 4900 9700"/>
@behrisch @ritzerp needs somebody for the C++ part of the work but wants to contribute by writing tests or similar.
@bcoueraud87 you were assigned to #13489, do you still want to work on this?
Loading all the new values from <param>
might speed up implementation a bit but has the disadvantage of preventing schema validation. Since its already common for carFollowModels to have plenty of parameters (i.e. 17 for EIDM) we could easily add 6 for the equation style (mass already exists) and another 3 for the value tables.
@bcoueraud87 you were assigned to #13489, do you still want to work on this?
No thank you.
by convention, the value tables for resistance and traction use speed in km/h whereas sumo uses m/s almost everywhere. @behrisch , @ritzerp Should we rather break convention or consistency here?
@ritzerp, it looks as if your example gives maximumTraction in kN rather than N. I actually find this more practical (also using kW for maximumPower instead of W). For consistency, this would also imply scaling the resistance coefficients so that the formula returns kN.
@behrisch would your rather have the pure SI units though?
some implementation notes:
After a short discussion the current preference is m/s and kN everywhere
Sorry for late reply. I think I prefer consistency within SUMO and use m/s. I also support the decision to use kN, since forces are quite high for trains. As long as it is documented, this should be fine.
Introduction
Theory and assumptions
A: Train dynamics from equations
requires trainType custom and the following parameters
XML example
Equations for traction and resistance forces
equation for traction force in N
equation for resistance force in N
B:Train dynamics from tables
requires trainType custom and the following parameters
speed values inbetween are interpolated
XML example
Units
Proposed physical units
Notes on implementation
Discussion
The accel value could be used to estimate maximumTraction:
The speed could be given in m/s instead of km/h, but this seems more uncommon.