search

eclipse-sumo / sumo

Eclipse SUMO is an open source, highly portable, microscopic and continuous traffic simulation package designed to handle large networks. It allows for intermodal simulation including pedestrians and comes with a large set of tools for scenario creation.
https://eclipse.dev/sumo
Eclipse Public License 2.0
2.51k stars 1.42k forks source link

missing connections after adding edge #14391

Closed namdre closed 6 months ago

namdre commented 7 months ago

Expectation (working in 1.18): there is a connection between the edges Observation (1.19): missing connection

I'm guessing this is closer to the root cause for #13699

namdre commented 7 months ago

level of criticality: If nothing else we're broken I would want to do a hotfix release for this!

namdre commented 7 months ago

@palvarezlopez I'll do a git bisect but will probably have to discuss things with you.

namdre commented 7 months ago

It's a mess. The problem could be anywhere between 5f1b4aee02e35f9bacf83d4ce0c3ee530038a9eb and 36d4c2a168a82493398ef4dd0e14fcb1e8b74e38. In between, the build is broken (at least on linux). Thats 47 candidate commits. Full bisect log is attached 14391.bisectlog.txt

and here is a combined diff for all the candidate commits: https://github.com/eclipse-sumo/sumo/compare/5f1b4aee02e35f9bacf83d4ce0c3ee530038a9eb..36d4c2a168a82493398ef4dd0e14fcb1e8b74e38

palvarezlopez commented 7 months ago

@namdre can you filter in the bisect all #13667 tickets? (is the JuPedSim Ticket)

namdre commented 7 months ago

I cannot filter the diff any further. However, if you can (locally) fix the build for versions between the last known good and the first known bad version, you can check whether they are affected by the problem an we can get a smaller range and shorter diff.

palvarezlopez commented 6 months ago

Broken in https://github.com/eclipse-sumo/sumo/commit/436f243bf8bf83b31fe33a07f3346c7716cad5bb