search

eclipse-sumo / sumo

Eclipse SUMO is an open source, highly portable, microscopic and continuous traffic simulation package designed to handle large networks. It allows for intermodal simulation including pedestrians and comes with a large set of tools for scenario creation.
https://eclipse.dev/sumo
Eclipse Public License 2.0
2.55k stars 1.43k forks source link

NEMA should allow configurable "detector lock" for the nextPhase logic #9989

Open mschrader15 opened 2 years ago

mschrader15 commented 2 years ago

NEMA users should be able to configure whether the detector are "locked" at the begging or ending of yellow. In the Econolite I am testing against, this is actually configurable on the detector level.

We don't currently distinguish between detector lock & the next phase algorithm. @qichaow do you think it is worthwhile to allow per-detector lock configuration in the vein of #9983 or just do a general parameter?

https://github.com/eclipse/sumo/blob/bab4b98f54ca2c2ae832a02c856e84f495844d78/src/microsim/traffic_lights/NEMAController.cpp#L926-L942

qichaow commented 2 years ago

@mschrader15 Hi Max,

What does detector lock do?

Qichao

mschrader15 commented 2 years ago

@qichaow it basically freezes the detector states at a certain point in time before the next phase is calculated.

On the Econolite that I am working with, there is a choice between the start of yellow or the start of red.

qichaow commented 2 years ago

Thanks. How about we start with a general parameter for now? We can take more parameters when we have a good GUI to hide/expand parameters.

We should probably have a priority list for adding features to the NEMA type controller so that we can capture the most used features first.

On Tue, Jan 18, 2022 at 8:20 PM Max Schrader @.***> wrote:

@qichaow https://github.com/qichaow it basically freezes the detector states at a certain point in time before the next phase is calculated.

On the Econolite that I am working with, there is a choice between the start of yellow or the start of red.

— Reply to this email directly, view it on GitHub https://github.com/eclipse/sumo/issues/9989#issuecomment-1016041663, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADYWAWBBTFSAT5C4GTXHR6LUWYUYFANCNFSM5MIUW5QQ . You are receiving this because you were mentioned.Message ID: @.***>

mschrader15 commented 2 years ago

Along the same lines, this should also support latching detectors. I am seeing differences in testing due to this

mschrader15 commented 2 years ago

Latching detectors implemented with #10598

namdre commented 2 years ago

@mschrader15 can this issue be closed?

mschrader15 commented 2 years ago

@namdre latching is different than the lock. I don't have a use case for building in the detector lock anymore, so could close it and reopen if someone else wants detector lock options.