search

eclipse-sw360 / sw360-frontend

SW360 Frontend Project
Eclipse Public License 2.0
12 stars 9 forks source link

feat(packages): Add package details page #297

Closed deo002 closed 3 months ago

deo002 commented 4 months ago

Url

http://localhost:3000/packages/detail/{id}

Screenshots

image

deo002 commented 4 months ago

The css was used locally at many places. Making it global required changes in a lot of places which made the PR big. Should I add the second commit in another PR? @heliocastro

heliocastro commented 3 months ago

The css was used locally at many places. Making it global required changes in a lot of places which made the PR big. Should I add the second commit in another PR? @heliocastro

Yes, you should. The fact is using in a lot places is enough information that should be global. Local solution just hurt maintenance, quality of the code, and future possible changes

deo002 commented 3 months ago

The css was used locally at many places. Making it global required changes in a lot of places which made the PR big. Should I add the second commit in another PR? @heliocastro

Yes, you should. The fact is using in a lot places is enough information that should be global. Local solution just hurt maintenance, quality of the code, and future possible changes

Ok, I'll add the follow up PR after rebasing once this one is merged.

heliocastro commented 3 months ago

@deo002 You need rebase this commit

deo002 commented 3 months ago

I will merge this one. @deo002 Please fix this. I will remember you from now one every time you make a new PR, until this is fixed. @hoangnt2 We should do a cleanup on CSS, and after that forbid any of this things again.

I'll push a fix right after this is merged