search

eclipse-sw360 / sw360

SW360 project
https://www.eclipse.org/sw360/
Other
123 stars 99 forks source link

There are many "Visbility" in source code. Are these typo? Should we rewrite to "Visibility" them for readability? #1311

Open KoukiHama opened 3 years ago

KoukiHama commented 3 years ago

Description

In the long run, we should modify them, but I don't know how impactful these changes

https://github.com/eclipse/sw360/search?q=Visbility

Example

https://github.com/eclipse/sw360/blob/d4599a23d5f0b24dcc0993cad861083425273cc9/backend/src-common/src/main/java/org/eclipse/sw360/datahandler/entitlement/ProjectModerator.java#L115-L116

Steps followed and expected result

Describe the steps followed by you and your expected results after following the steps.

Screenshots

If applicable, add screenshots to help explain your problem.

quan-tv commented 3 years ago

All of this typo mistakes is related to Project, because when define the structure of Project table in DB, the name of the field was set to 'visbility', instead of 'visibility'.

image

Correcting the source code will not cost much effort, but we will also need to re-test all related functions.

KoukiHama commented 3 years ago

Related to this issue,

Recently I rewrite code step by step about this.

Slack link

There is a mixture of British and American English in the SW360 code.

Example:　organi"z"ation and organi"s"ation https://github.com/eclipse/sw360/search?q=organisation https://github.com/eclipse/sw360/search?q=organization

I will replace all and make pull request... then I use organi"z"ation if nobody disagree…