eclipse-sw360 / sw360

SW360 project
https://www.eclipse.org/sw360/
Other
119 stars 98 forks source link

Data Lost Through Form Resubmission #338

Closed alexbrdn closed 3 years ago

alexbrdn commented 6 years ago

When a user updates a project, then closes the browser tab and reopens it, the edit form gets resubmitted, but not with all the data, as one would expect. The portlet then performs an update of the project and deletes all linked releases, linked projects, unchecked attachments, etc.

Testing with Chrome, revealed these lists of parameters submitted to portlet: Normal update: javax.portlet.action, projectid, OWNER_ACCOUNTING_UNIT, PREEVALUATION_DEADLINE, SECURITY_RESPONSIBLES, CLEARING_TEAM, ATTACHMENTSFILENAME, STATE, ATTACHMENTSCHECK_STATUS, PROJECT_RESPONSIBLE, OWNER_GROUP, DESCRIPTION, PHASE_OUT_SINCE, RELEASE_ID_TO_USAGERELEASE_RELATION, WIKI, SYSTEM_TEST_START, HOMEPAGE, CONTRIBUTORS, ATTACHMENTSCREATED_COMMENT, SYSTEM_TEST_END, CLEARING_STATE, CREATED_BY, PROJECT_TYPE, ATTACHMENTSCHECKED_COMMENT, VISBILITY, RELEASE_ID_TO_USAGEMAINLINE_STATE, BUSINESS_UNIT, OWNER_COUNTRY, NAME, MODERATORS, ATTACHMENTSATTACHMENT_CONTENT_ID, VERSION, RELEASE_ID_TO_USAGEID, moderation_request_comment, DELIVERY_START, TAG, LEAD_ARCHITECT, PROJECT_OWNER, ATTACHMENTSATTACHMENT_TYPE

Form resubmittion: javax.portlet.action, projectid

Note, that we implemented this workaround previously, when we didn't know what caused the data loss.

Similar effect may be caused by resubmitting the component, release and other editing forms.

alexbrdn commented 6 years ago

The perfect solution is probably to prevent form resubmission at all

mcjaeger commented 3 years ago

was also discussed this week and solved.