eclipse-symphony / symphony

Symphony project
MIT License
24 stars 17 forks source link

Helm target provider doesn't set the namespace correctly #222

Closed msftcoderdjw closed 4 weeks ago

msftcoderdjw commented 1 month ago

image

When using the Helm SDK, Each action (install, update, uninstall, list) uses the actionConfig to talk to the Kubernetes cluster. The action config is initialized with an environment configuration that would be used for the Kubernetes client and a namespace that would be used for the release.

The problem was when creating actionConfig, current logic always defaults to default namespace. So even if we can see the pods are running on expected namespace, but helm list -n <namespace> will return wrong values. https://github.com/eclipse-symphony/symphony/blob/6a7d8fe6ae0e93b50dde1079208aa07bfea80551/api/pkg/apis/v1alpha1/providers/target/helm/helm.go#L174-L179

msftcoderdjw commented 1 month ago

This issue is fixed in ADO codebase, will include in PR #220