search

eclipse-symphony / symphony

Symphony project
MIT License
24 stars 17 forks source link

Remove version from InstanceSpec #235

Closed msftcoderdjw closed 3 weeks ago

msftcoderdjw commented 3 weeks ago

https://github.com/eclipse-symphony/symphony/blob/5785f0321395de5a4a4d04a7cea74eb6cdc40f09/api/pkg/apis/v1alpha1/model/instance.go#L23-L39

msftcoderdjw commented 3 weeks ago

Hi @nonsocode , could you please double confirm if we can remove version from InstanceSpec? Like @Haishi2016 mentioned, this was introduced by AIO.

msftcoderdjw commented 3 weeks ago

I found I used to check this field with @nonsocode , this property is not used.

Quoted from @nonsocode 's reply:

Version isn't really used. It was an experimental idea that ended up being unused so it can be safely removed.

I will delete this field in K8S merge code PR. @Haishi2016 .