search

eclipse-symphony / symphony

Symphony project
MIT License
37 stars 29 forks source link

[Multisite]Change ObjectMeta.Generation to int or Rename Generation field #360

Open RemindD opened 3 months ago

RemindD commented 3 months ago

The Generation in kubernetes API is int type. https://github.com/kubernetes/apimachinery/blob/ab0686929a37e76aa02cc8948f1449ba055160c2/pkg/apis/meta/v1/types.go#L177C1-L177C88

We can get error like "cannot unmarshal string into Go struct field ObjectMeta.generation of type int64“ using k8s state provider to create or update symphony objects if generation is not empty.

msftcoderdjw commented 3 months ago

Impact in multi-site in sync case, or users supply generation in objectMetadata in materialize case (?valid scenario.)