search

eclipse-symphony / symphony

Symphony project
MIT License
34 stars 26 forks source link

error message bug(helm target provider) #378

Open yanjiaxin534 opened 1 month ago

yanjiaxin534 commented 1 month ago

Step1: use error helm repo to deploy target. -> deployment will failed. Step 2: change to correct helm repo to deploy target. -> deploy will succeed with last step's error message.

msftcoderdjw commented 1 month ago

The repro steps are little bit complicated. I have found the root causes. Let's discuss in tomorrow's sync up. Then I can update the final discussion results here.

msftcoderdjw commented 1 month ago

This was identified with two observed issues. 1) status.targets.xxx's error message won't be reset if current deployment is succeeded. 2) In update scenario, if users' input doesn't include the required fields, the target provider validation rule will be skipped since the change field has no changes. But if it is fresh new deployment, target provider validation rule will fail since the input doesn't include the required fields. (The behavior is not aligned.)

msftcoderdjw commented 2 days ago

Assigned to @yanjiaxin534