search

eclipse-symphony / symphony

Symphony project
MIT License
27 stars 17 forks source link

Find a catalog object in correct namespace #50

Closed eedorenko closed 3 months ago

eedorenko commented 4 months ago

While finding a catalog object for a solution, use the solution's scope/namespace, rather than using "default".

Fixes #17

msftcoderdjw commented 3 months ago

@eedorenko , would you please rebase your code with latest main? We recently added many tests for catalogs. Please make sure your changes have passed these checks. (Go action will be retriggered in your new push, you may need to fix the tests if your change here modify the function signature).

Meanwhile, do you have any validations on your unblocked scenario? I noticed in you mentioned in #17 we need to find catalog in solution scope/namespace. Have you tested your change when solution / catalog is in default and non-default namespace? Have you validated multi-site deployment?

eedorenko commented 3 months ago

@msftcoderdjw

would you please rebase your code with latest main? We recently added many tests for catalogs. Please make sure your changes have passed these checks. (Go action will be retriggered in your new push, you may need to fix the tests if your change here modify the function signature).

Done

Meanwhile, do you have any validations on your unblocked scenario? I noticed in you mentioned in https://github.com/eclipse-symphony/symphony/issues/17 we need to find catalog in solution scope/namespace. Have you tested your change when solution / catalog is in default and non-default namespace? Have you validated multi-site deployment?

Yes, the point of the PR is to address #17 and nothing else. It has been tested with having solution/catalog in the default and non-default namespaces.

I haven't tested it for the multi-site deployment.

eedorenko commented 3 months ago

Resolved the conflicts and retested.