eclipse-syson / syson

SysON: web-based graphical modelers for SysMLv2. Please visit https://mbse-syson.org and contact Obeo https://www.obeosoft.com/en/contact for more details!
https://mbse-syson.org
Eclipse Public License 2.0
101 stars 28 forks source link

Restrict possible targets for Semantic Drag&Drop #223

Open jessymallet opened 6 months ago

jessymallet commented 6 months ago

Semantic Drag&Drop, i.e. from explorer view on diagram, could be improved.

Indeed, implemented tools authorize to semantic Drag&Drop every element on the background of the diagram (it is OK) and on every container node even if this is not its semantic parent.

For example, we can Drag&Drop a Package in its own representation and so on. There is no sense to have this kind of representation and it brings confusion. It should be forbidden.

Expected behavior :

It should be interesting to authorize semantic Drag&Drop on background of diagram and on their semantic/graphical parent only.

Actual screenshot behavior :

semanticDrag Drop

stephanelacrampe commented 6 months ago

I don't agree with "It should be interesting to authorize semantic Drag&Drop on background of diagram and on their semantic/graphical parent only.". It conflicts with the features that is moving a part under a package when drag&dropping it from a diagram. Let me explain: let's say a user wants to D&D a part from the explorer to a diagram on an existing package, but not the one in which the part is under: then it would prevent from doing it. But once it is on the diagram, then you can move the same part under the same package on the diagram (not from the explorer) and it would move the part semantically under this package. The user won't understand why it can do it on the diagram but not from the explorer. To me, the rules should be: