eclipse-theia / generator-theia-extension

A Yeoman generator for extensions to the Theia IDE
Other
49 stars 37 forks source link

Update ts-node version to resolve test issues #150

Closed seltzered closed 2 years ago

seltzered commented 2 years ago

Update ts-node version in theia generator extension to resolve an issue where:

yarn test
yarn run v1.22.15
$ cd theia-widget-demo && yarn test
warning package.json: No license field
$ jest --config configs/jest.config.ts
Error: Jest: Failed to parse the TypeScript config file /[...]/theia-widget-demo/theia-widget-demo/configs/jest.config.ts
  Error: Debug Failure. False expression: Non-string value passed to `ts.resolveTypeReferenceDirective`, likely by a wrapping package working with an outdated `resolveTypeReferenceDirectives` signature. This is probably not a problem in TS itself.
    at readConfigFileAndSetRootDir (/[...]/theia-widget-demo/node_modules/jest-config/build/readConfigFileAndSetRootDir.js:150:13)
    at readConfig (/[...]/theia-widget-demo/node_modules/jest-config/build/index.js:210:18)
    at readConfigs (/[...]/theia-widget-demo/node_modules/jest-config/build/index.js:406:26)
    at runCLI (/[...]/theia-widget-demo/node_modules/@jest/core/build/cli/index.js:230:59)
    at Object.run (/[...]/theia-widget-demo/node_modules/jest-cli/build/cli/index.js:163:37)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
JonasHelming commented 2 years ago

@seltzered Thank you for the contribution! Would you mind signing the ECA, so we can accept it?

seltzered commented 2 years ago

Done. Had issues last week but revalidated today and seems to pass now. (also, some context, this PR was inspired by https://stackoverflow.com/questions/72586253/typescript-debug-failure-false-expression-non-string-value-passed-to-ts-reso )

JonasHelming commented 2 years ago

Thank you for this contribution!