search

eclipse-theia / generator-theia-extension

A Yeoman generator for extensions to the Theia IDE
Other
49 stars 37 forks source link

Add GLSP diagram editor extension #153

Closed planger closed 2 years ago

planger commented 2 years ago

This extension can generate diagram editors based on the GLSP examples with Java or nodejs backend and package it as Theia extension or VS Code extension.

Co-authored-by: Max Elia max_elia@hotmail.de Co-authored-by: Florian Gareis dev@zoker.me

Closes https://github.com/eclipse-theia/generator-theia-extension/issues/110

planger commented 2 years ago

I was unable to generate the GLSP template with Node 12. We should probably introduce a dependecy on >= Node 14

Right, I guess that's also true for all other templates as Theia itself requires Node >= 14.

Anyway, we'll add an engines entry to the package.json of the GLSP project example and move the tag. I'll track that in https://github.com/eclipse-glsp/glsp/issues/676. Thus, this PR doesn't need to be changed in this regard.

JonasHelming commented 2 years ago

I was unable to generate the GLSP template with Node 12. We should probably introduce a dependecy on >= Node 14

Right, I guess that's also true for all other templates as Theia itself requires Node >= 14.

Anyway, we'll add an engines entry to the package.json of the GLSP project example and move the tag. I'll track that in eclipse-glsp/glsp#676. Thus, this PR doesn't need to be changed in this regard.

Yes and also: https://github.com/eclipse-theia/generator-theia-extension/issues/154

JonasHelming commented 2 years ago

The following comment brings up similar concerns I had with the previous pull-request (#111 (review)):

This extension can generate diagram editors based on the GLSP examples with Java or nodejs backend and package it as Theia extension or VS Code extension.

Do we really want to include a generator that is so specific, and which can also provide a vscode extension? The repository is meant to easily get started and create your own Theia extension but now we are starting to mix concepts. For something as specific as glsp is it not better in it's own repository? Is there a need to have it in the upstream generator?

For the VS Code extension path, I agree, I would simply remove it. For the Theia extension path, I would very much prefer to have it here. From the view point of a Theia user, it is an interesting capability to explore. Even if the diagram editor is provided by GLSP, it shows a strength of Theia. The generated template is a Theia extension + a Theia example application. This question we already discussed here: https://github.com/eclipse-theia/generator-theia-extension/pull/111#issuecomment-856635841

So my proposal is to remove the VS Code path and keep the rest as is, are you fine with this? @vince-fugnitto

vince-fugnitto commented 2 years ago

@JonasHelming I won't block the pull-request but I'm not entirely confident in the way we consume the glsp-example (it would likely be better suited as an example repository) and the fact we need to fetch the tar.gz and that it does not include any template file in this repository. I'm worried others may do the same and make the repository unmanageable (I already for instance cannot fix bugs in glsp).

If the way forward is to remove the vscode path then let's do that.

JonasHelming commented 2 years ago

VS Code template has been removed

JonasHelming commented 2 years ago

@vince-fugnitto Would it be possible to do a release of the generator?