search

eclipse-theia / generator-theia-extension

A Yeoman generator for extensions to the Theia IDE
Other
49 stars 37 forks source link

Generated electron-app does not work anymore #166 #167

Closed jfaltermeier closed 1 year ago

jfaltermeier commented 1 year ago

I think there are two fixes for this.

The first one would be to simply update the electron version in our template. However I believe with our recent changes, we may more easily update electron in the future. So this might change more often, requiring more regular fixes.

The second fix would be to remove the electron version from the template completely. When we invoke yarn for the first time, the theia build will patch the package.json and add the supported electron version. This requires a second invocation of yarn however, in order to install electron. So in the electron case we have to run yarn twice, when the electron version is removed from the template.

Fixes #166

jfaltermeier commented 1 year ago

Both fixes lead to green builds: 1) https://github.com/eclipse-theia/generator-theia-extension/actions/runs/4871969987 2) https://github.com/eclipse-theia/generator-theia-extension/actions/runs/4872257762

Without the fixes the daily build was failing: https://github.com/eclipse-theia/generator-theia-extension/actions

The current PR reflects the changes for 2), however I would just have to revert the last commit to get 1).

jfaltermeier commented 1 year ago

I don't know who would be the best person to review this, so please (re)assign reviewers as needed. :see_no_evil:

jfaltermeier commented 1 year ago

@vince-fugnitto I saw that you did the npm releases for the last Theia release: https://www.npmjs.com/org/theia Could you please publish a new release for the generator as well?

vince-fugnitto commented 1 year ago

@jfaltermeier done :) https://www.npmjs.com/package/generator-theia-extension?activeTab=versions