search

eclipse-theia / generator-theia-extension

A Yeoman generator for extensions to the Theia IDE
Other
49 stars 37 forks source link

Fix breaking change after inversify update #169

Closed msujew closed 1 year ago

msujew commented 1 year ago

With the latest Theia version (v1.39.0), components that use @postConstruct() are no longer allowed to return a promise in that function. This change fixes the issue in the widget that we distribute.

JonasHelming commented 1 year ago

@msujew Thanks for fixing this! Did you have a loom on why the tests fail?

JonasHelming commented 1 year ago

see: https://github.com/eclipse-theia/generator-theia-extension/blob/master/.github/workflows/generate-and-build-all-templates.sh

msujew commented 1 year ago

@JonasHelming Left an async where it didn't belong :)

Tests should work now.

vince-fugnitto commented 1 year ago

@msujew @JonasHelming just a heads-up I think I'll perform a release of the generator to include the fix :+1: