search

eclipse-theia / generator-theia-extension

A Yeoman generator for extensions to the Theia IDE
Other
49 stars 37 forks source link

bumped yeoman version to "^5.0.0", solves #182 #187

Closed sailingKieler closed 9 months ago

sailingKieler commented 9 months ago

@JonasHelming What do you think?

JonasHelming commented 9 months ago

Great! I will test once the build succeeds!

sailingKieler commented 9 months ago

@JonasHelming We need another build, a detail in yarn's handling of peer dependencies apparently hit me, and I didn't run the tests locally (on gitpod). I wasn't aware that the build needs a committer's approval.

JonasHelming commented 9 months ago

I already approved :-)

sailingKieler commented 9 months ago

🎉

🚀

sailingKieler commented 9 months ago

I spent additional time to convert the generator into an ESM package, and upgraded the version ^6.0.0 (just about to test with ^7.0.0). Are you guys interested in this addition upgrade?

JonasHelming commented 9 months ago

LGTM and works

JonasHelming commented 9 months ago

@vince-fugnitto I believe this with https://github.com/eclipse-theia/generator-theia-extension/pull/184 would justify a new release