search

eclipse-theia / generator-theia-extension

A Yeoman generator for extensions to the Theia IDE
Other
56 stars 40 forks source link

Add build step to generate and compile all templates #98

Closed JonasHelming closed 3 years ago

JonasHelming commented 3 years ago

Added a build step that generated and compiles a templates and fails the build if any template fails to build. How to test: Introduce a change in a template that fails its build. fixed #95 Signed-off-by: Jonas Helming jhelming@eclipsesource.com

vince-fugnitto commented 3 years ago

I created a test pull-request to verify if the workflow correctly fails https://github.com/eclipse-theia/generator-theia-extension/pull/101. I'll check if it fails the build, and if multiple templates fail it will display their results (and not fail fast).

JonasHelming commented 3 years ago

I created a test pull-request to verify if the workflow correctly fails #101. I'll check if it fails the build, and if multiple templates fail it will display their results (and not fail fast).

done!

vince-fugnitto commented 3 years ago

@JonasHelming do you think we would benefit from running the CI (including generation and building) as part of a cron job? We can potentially identify breaking issues earlier.

JonasHelming commented 3 years ago

Good idea, will do: https://github.com/eclipse-theia/generator-theia-extension/issues/102