search

eclipse-theia / theia-blueprint

The Eclipse IDE is a modern and open IDE for cloud and desktop. The Theia IDE is based on the Theia platform. The Theia IDE is available as a downloadable desktop application. You can also try the latest version of the Theia IDE online. For more details, see the Readme below.
https://theia-ide.org/#theiaide
MIT License
335 stars 125 forks source link

Electron can't download update. #273

Closed hyy215 closed 1 year ago

hyy215 commented 1 year ago

Bug Description:

Electron can't download update.

Steps to Reproduce:

  1. Download and install 1.37.0.
  2. Choose yes to update.
  3. Always waiting for downloading. 7e6605c6ac0b9c6a40bcaa036f1dcb3

https://github.com/eclipse-theia/theia-blueprint/blob/5fe2d301210a4e4fdde8e5eb91a25988214cacbf/theia-extensions/theia-blueprint-updater/src/electron-browser/updater/theia-updater-frontend-contribution.ts#L33 https://github.com/eclipse-theia/theia-blueprint/blob/5fe2d301210a4e4fdde8e5eb91a25988214cacbf/theia-extensions/theia-blueprint-updater/src/electron-browser/updater/theia-updater-frontend-contribution.ts#L188-L208

nodeIntegration: false in theia default config. Beginning in Electron 20, renderers will be sandboxed by default and preload scripts hadn't access to Node.js. https://www.electronjs.org/blog/electron-20-0#default-changed-renderers-without-nodeintegration-true-are-sandboxed-by-default

Additional Information

jfaltermeier commented 1 year ago

Thank you for the report, I will have a look at fixing this in the next days