Rename theia-updater to @theia/electron-updater

eclipse-theia / theia-blueprint

The Eclipse IDE is a modern and open IDE for cloud and desktop. The Theia IDE is based on the Theia platform. The Theia IDE is available as a downloadable desktop application. You can also try the latest version of the Theia IDE online. For more details, see the Readme below.

https://theia-ide.org/#theiaide

MIT License

327 stars 120 forks source link

Rename theia-updater to @theia/electron-updater #44

Open JonasHelming opened 3 years ago

JonasHelming commented 3 years ago

After splitting the updater from the rpdocut branding (https://github.com/eclipse-theia/theia-blueprint/pull/43) we should consider renaming the updater extension. It is actually generic, so it could potentially be reused by any other application relying on the electron updater.

koegel commented 3 years ago

Should we not also move the updater to the Theia repo, @JonasHelming?

JonasHelming commented 3 years ago

Yes, mid term this would probably make sense.

marcdumais-work commented 3 years ago

We are free to move code around within the project, so it's totally up-to us.

vince-fugnitto commented 3 years ago

Should we not also move the updater to the Theia repo, @JonasHelming?

Before we think about moving, we should consider the following:

Adding a readme to properly describe this extension (like other extensions).
We should only add extensions if they can be easily tested when using example-electron (even manually). Does this extension provide any functionality that can be easily tested with example-electron or is it only useful for packaged electron applications?

seltzered commented 1 year ago

From my initial newbie look at theia-updater one may want to consider breaking out the url/directory strings in theia-updater-impl.ts into something configurable.

koegel commented 1 year ago

From my initial newbie look at theia-updater one may want to consider breaking out the url/directory strings in theia-updater-impl.ts into something configurable.

This would make sense and we would accept a PR, currently we have no plans to make the updater more generic, therefore we put it in the Backlog milestone some time ago.