search

eclipse-theia / theia-cloud-helm

Eclipse Public License 2.0
6 stars 7 forks source link

Add conditional install for CA and Prod ClusterIssuer #60

Closed iyannsch closed 5 months ago

iyannsch commented 5 months ago

Currently, the theia.cloud-base helmchart always installs three ClusterIssuer: issuerca, issuerprod, and issuerstaging. This might make sense for a testing environment or a cluster just serving Theia but might be unnecessary for those environments in which ClusterIssuers are already handled. According to @jfaltermeier it would be useful to opt-out of automatic installs of issuerca, issuerprod. Fixes #50.

My changes introduce two new useExisting values that disable the creation of new ClusterIssuer. issuerstaging is always created as required for testing.

iyannsch commented 5 months ago

Thanks for you comment and feedback @lucas-koehler,

I addressed your changes and request a new review from your end :)

Please do enjoy your vacation, looking forward to hearing from you in July ☺️

iyannsch commented 5 months ago

@lucas-koehler Thanks for your review! I incorporated all your suggestions and rebased to ensure a clean merge :)