eclipse-theia / theia-cloud

Eclipse Public License 2.0
61 stars 34 forks source link

Provide conversion webhook for CRDs #283

Closed sgraband closed 8 months ago

sgraband commented 8 months ago

Webhook is called, whenever a CR is requested in a specific version. This allows for a better updating path, as old CRs are still useable.

[conversion] Provide conversion java project:

[common] Add Hub and previous version for all CRDs

[operator] Adjust operator so it works with the above changes.

[service] Adjust service so it works with the above changes.

[documentation] Add build command for conversion-webhook

[.github] Add ci for conversion-webhook

Contributed on behalf of STMicroelectronics Co-authored-by: Johannes Faltermeier jfaltermeier@eclipsesource.com

Helm-repo PR: https://github.com/eclipsesource/theia-cloud-helm/pull/49 Fixes #203, #212 and #161.

jfaltermeier commented 8 months ago

I've pushed some missing eclipse metadata files and opened all java projects with Eclipse (2023-03), VSCode, and the TheiaIDE and committed the resulting updates to the metadata files.

jfaltermeier commented 8 months ago

I noticed that there are some left over theia.cloud/v1beta8 AppDefinition references in: demo/dockerfiles/demo-operator-custom-template/templateDeployment.yaml demo/dockerfiles/demo-operator-custom-template/templateDeploymentWithoutOAuthProxy.yaml helm/theia.cloud/test/cdt.yaml terraform/test-configurations/2-01_try-now/theia_cloud.tf terraform/test-configurations/2-03_try-now_paths/theia_cloud.tf

jfaltermeier commented 8 months ago

I've pushed some missing eclipse metadata files and opened all java projects with Eclipse (2023-03), VSCode, and the TheiaIDE and committed the resulting updates to the metadata files.

Could you please check if you get changes on the settings in different IDEs? If yes we should check if we can fix this (probably in a follow up ticket), because the settings should not get added to .gitignore, if possible.

sgraband commented 8 months ago

Could you please check if you get changes on the settings in different IDEs? If yes we should check if we can fix this (probably in a follow up ticket), because the settings should not get added to .gitignore, if possible.

Looks good on my side. Tested also with VSCode, TheiaIDE and Eclipse